Fix interactive file ignore addition #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add basic talismanrc with go scope - Change TalismanRCIgnore methods to exist on pointer receiver - Move TalismanRCIgnore and associated structs to talismanrc package - Use simple config for automated git testing
svishwanath-tw
force-pushed
the
file_ignore_refactor
branch
2 times, most recently
from
c3b3c03
to
9d98956
Compare
svishwanath-tw
force-pushed
the
file_ignore_refactor
branch
from
9d98956
to
424882a
Compare
tinamthomas
reviewed
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update existing entries instead of creating duplicates in interactive mode (See #171 for details)
This PR also introduces a package for all things related to talismanrc reading/manipulation