Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #185:Changed the pattern checking for passwords to verify strin… #188

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

harinee
Copy link
Collaborator

@harinee harinee commented Mar 28, 2020

Closes Issue #185

  • Refactored the regex code to add checks for any string preceding or succeeding the passphrases (password|passphrase|pwd|pword|pass)
  • Added checks for new passphrases (secret|key) to the above list
  • Reduced possible false positives for 'pw', since it is too short, by introducing a specific patter to look for
  • Added tests for the above, including negative scenarios

Note: Have not considered that the following tests should pass, because adding this logic will not let talisman remain tech stack agnostic
setPassword("12345678") and setenv(password, "12345678")

…verify strings succeeding the password phrase. Also added more phrases to check for and tests for the same
@svishwanath-tw svishwanath-tw merged commit 54a328d into thoughtworks:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants