Adding experimental configuration that lets you set a base64 entropy … #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svishwanath-tw
approved these changes
Jun 1, 2020
|
…threshold we discovered, that Talisman did not detect a accidentally added Azure System Access Token, due to its detected base64 threshold being slightly below the detection threshold. this change lets you add a section ```yaml experimental: base64EntropyThreshold: 4.0 ``` to your `.talismanrc` yaml file that allows you to overwrite this threshold individually. In our case lowering the threshold from 4.5 to 4.0 enabled us to detect the secret as such and did the job. Signed-off-by: Michael Lihs <michael.lihs@thoughtworks.com>
|
Re-created the fork due to issues with signing. So I will close the PR and create a new one. Sorry for the trouble... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered, that Talisman did not detect a accidentally added Azure System Access Token, due to its detected base64 threshold being slightly below
the detection threshold. this change lets you add a section
to your
.talismanrcyaml file that allows you to overwrite this threshold individually. In our case lowering the threshold from 4.5 to 4.0 enabled us to detectthe secret as such and did the job.