Consider the wildcard in talismarc file #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dinesh <dineshudt17@gmail.com>
Signed-off-by: Dinesh <dineshudt17@gmail.com>
Signed-off-by: Dinesh <dineshudt17@gmail.com>
svishwanath-tw
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #191
Previously detectors needed only the
current git additions(for commit hook: staged files, for push hook: unpushed commit's files).In order to support regex patterns in talismanrc, we have to consider all the files that are tracked in git. So I am injecting all the tracked files to checksumCompare and finding the checksum for all the files which matches the pattern.
In order to write proper unit test for
checksum_compare.go, we have to injectutilityto that file. So that we can inject mock utility and write better tests. I will start adding that if the current code is okay.