Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail talisman if severity above threshold as defined in talismanRC(#114) #215

Merged
merged 2 commits into from Aug 3, 2020
Merged

Fail talisman if severity above threshold as defined in talismanRC(#114) #215

merged 2 commits into from Aug 3, 2020

Conversation

tinamthomas
Copy link
Collaborator

@tinamthomas tinamthomas commented Jul 25, 2020 •
edited

  • Readme updated, see Configuring severity threshold section
  • TalismanRC configuration for threshold severity. Default threshold is Low.
  • Severity values range between 1(Low), 2(Medium), 3(High)
  • pre-commit fails if eq or above threshold. If below threshold, only adds to warnings list
  • custom patterns for detection are added as high severity patterns

@tinamthomas tinamthomas linked an issue Jul 26, 2020 that may be closed by this pull request
Add capability of defining failure threshold on CLI #114
Closed
@svishwanath-tw
Copy link
Collaborator

👍 . Great work on the PR.
I wonder if values like 1,2,3 can be ... more user friendly ?
Could we look for strings high, medium, low instead ?
What do others think @harinee @dineshba ?

dineshba
dineshba approved these changes Jul 26, 2020
View reviewed changes
Copy link
Collaborator

@dineshba dineshba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tinamthomas
Copy link
Collaborator Author

@svishwanath-tw I think it makes sense to make it more user-friendly. I'll update the MR accordingly.

@tinamthomas
Copy link
Collaborator Author

@svishwanath-tw @dineshba Can I merge this?

@svishwanath-tw
Copy link
Collaborator

@tt-official @dineshba I gave my approval long time ago. I will merge now.

@svishwanath-tw svishwanath-tw merged commit b94762f into thoughtworks:master Aug 3, 2020
harinee pushed a commit to harinee/talisman that referenced this pull request Aug 9, 2020
@tinamthomas @harinee
Fail talisman if severity above threshold as defined in talismanRC(th…
f5d9770 
…oughtworks#114) (thoughtworks#215)

* Fail talisman if severity above threshold as defined in talismanRC(thoughtworks#114)
* Use string values for defining severity threshold (thoughtworks#114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dineshba dineshba dineshba approved these changes

@svishwanath-tw svishwanath-tw svishwanath-tw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add capability of defining failure threshold on CLI
3 participants
@tinamthomas @svishwanath-tw @dineshba