New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue #247] ♻️ remove dependency on talisman_hook_script #254

Merged

svishwanath-tw merged 2 commits into thoughtworks:master from derwent-m:feature/refactor_install

Sep 11, 2020

Contributor

derwent-m commented Sep 10, 2020 •

edited

Loading

Changes affecting install.sh (script used to install talisman to a single repo, not to be confused with global_install_scripts/install.bash ):

install.sh uses ancient talisman release because newer binaries are incompatible with script. #247
- remove dependency on talisman_hook_script
- refactor heredoc hook script to minimise complexity

I refined my original solution because it would be better if this just used the features it actually needed from talisman_hook_script instead of depending on the entire script


          [Issue thoughtworks#247] ♻️ remove dependency on talisman_hook_script

e4f88c7

Collaborator

svishwanath-tw commented Sep 10, 2020

But .. wai ?

Contributor Author

derwent-m commented Sep 11, 2020

But .. wai ?

The original solution was a hack, this is slightly less of a hack, and is less likely to break if someone updates talisman_hook_script, open to any feedback or suggestion you have on how to improve though :)


          ♻️ further reduce complexity of install.sh

420623f

Contributor Author

derwent-m commented Sep 11, 2020

@svishwanath-tw I should point out that these changes affect install.sh which is the script used to install talisman to a single repo, not to be confused with global_install_scripts/install.bash

svishwanath-tw approved these changes

View reviewed changes

svishwanath-tw merged commit 9abe2ba into thoughtworks:master

svishwanath-tw added a commit to svishwanath-tw/talisman that referenced this pull request


          thoughtworks#254 | Ignore specs and scan results are dependent talism…

…an invocation mode

svishwanath-tw added a commit that referenced this pull request


          #254 | Implementignore for scans

f5f330d

- Separate runtime configuration from persisted configuration in talismanRC
- Fix JSON Marshalling of severity values
- Remove Mode member from TalismanRC
- Upgrade yaml and testify versions

svishwanath-tw added a commit that referenced this pull request


          Issue #254 | Implementignore for scans

da16435

- Separate runtime configuration from persisted configuration in talismanRC
- Fix JSON Marshalling of severity values
- Remove Mode member from TalismanRC
- Upgrade yaml and testify versions

svishwanath-tw added a commit that referenced this pull request


          #254 | Ignore specs and scan results depend on invocation mode

ae1f9c3

- Misc code cleanup and test refactorings

svishwanath-tw added a commit that referenced this pull request


          #254 | Ignore specs and scan results are dependent talisman invocatio…

b6e2467

…n mode

svishwanath-tw added a commit that referenced this pull request


          Issue #254 | Implementignore for scans

665b04a

- Separate runtime configuration from persisted configuration in talismanRC
- Fix JSON Marshalling of severity values
- Remove Mode member from TalismanRC
- Upgrade yaml and testify versions

svishwanath-tw added a commit that referenced this pull request


          #254 | Ignore specs and scan results depend on invocation mode

38cbc4a

- Misc code cleanup and test refactorings

svishwanath-tw added a commit that referenced this pull request


          #254 | Ignore specs and scan results are dependent talisman invocatio…

a9f90b7

…n mode

svishwanath-tw added a commit that referenced this pull request


          Issue #254 | Implementignore for scans

b9f5f84

- Separate runtime configuration from persisted configuration in talismanRC
- Fix JSON Marshalling of severity values
- Remove Mode member from TalismanRC
- Upgrade yaml and testify versions

svishwanath-tw added a commit that referenced this pull request


          #254 | Ignore specs and scan results depend on invocation mode

681c9ad

- Misc code cleanup and test refactorings

svishwanath-tw added a commit that referenced this pull request


          #254 | Ignore specs and scan results are dependent talisman invocatio…

5cd45c6

…n mode

svishwanath-tw added a commit that referenced this pull request


          Issue #254 | Implementignore for scans

b8caeb7

- Separate runtime configuration from persisted configuration in talismanRC
- Fix JSON Marshalling of severity values
- Remove Mode member from TalismanRC
- Upgrade yaml and testify versions

svishwanath-tw added a commit that referenced this pull request


          #254 | Ignore specs and scan results depend on invocation mode

5b3548a

- Misc code cleanup and test refactorings

svishwanath-tw added a commit that referenced this pull request


          #254 | Ignore specs and scan results are dependent talisman invocatio…

d1d49c9

…n mode

svishwanath-tw added a commit that referenced this pull request


          Issue #254 | Implementignore for scans

dca2012

- Separate runtime configuration from persisted configuration in talismanRC
- Fix JSON Marshalling of severity values
- Remove Mode member from TalismanRC
- Upgrade yaml and testify versions

svishwanath-tw added a commit that referenced this pull request


          #254 | Ignore specs and scan results depend on invocation mode

5500fa2

- Misc code cleanup and test refactorings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment