Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows compatibility for single-project install using install.sh #259

Closed

Conversation

derwent-m
Copy link
Contributor

@derwent-m derwent-m commented Sep 19, 2020

Changes affecting install.sh (script used to install talisman to a single repo, not to be confused with global_install_scripts/install.bash ):

#198

  • add SHAs and OS detection for Windows to download windows binaries
  • correctly quote binary paths

Outstanding issues (existed before this PR):

@svishwanath-tw
Copy link
Collaborator

@derwent-m , @harinee has made changes for moving away from specific HASH checks to verifying against published checksums.
I'm closing this PR based on that.
Thanks for taking the time to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants