Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show progress bar on scanning #266

Merged
merged 1 commit into from Oct 15, 2020
Merged

Show progress bar on scanning #266

merged 1 commit into from Oct 15, 2020

Conversation

dineshba
Copy link
Collaborator

Initial attempt to show the progress bar.

Current approach:
total := len(currentAdditions) * len(dc.detectors)
After checking one addition with one detector, we will increase the count

Kapture 2020-10-14 at 19 42 20

@dineshba
Copy link
Collaborator Author

This will be applicable for pre-push and pre-commit hooks also. Should we disable for it ? @svishwanath-tw @harinee

@svishwanath-tw
Copy link
Collaborator

@dineshba : On dev machines, it will be informative to have. Only worry is what will happen on CI, will it break/distort the output ?

@dineshba
Copy link
Collaborator Author

I will just print the progress in stderr stream. Should not create any issues in the CI.

@svishwanath-tw svishwanath-tw merged commit 5f43824 into master Oct 15, 2020
@dineshba dineshba deleted the show-progress-bar branch October 19, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants