Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Windows server 2012 R2 #305

Merged

Conversation

g-prasanth
Copy link
Contributor

Adding support for Windows Server 2012 R2

@svishwanath-tw
Copy link
Collaborator

Hi @g-prasanth . Thanks for the PR. The fix looks simple enough.
I have 2 Questions before we proceed:

  1. have you tested that talisman install on windows 2012 with these changes
  2. Can we get away with MINGW64_NT-* instead of having to separate match clauses in installation ?

@g-prasanth
Copy link
Contributor Author

Hi @svishwanath-tw . Yes! I've tested the changes in Windows 2012 R2. I don't have enough setup to test the MINGW64_NT-* case.

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #305 (7f8353a) into master (95ae738) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #305   +/-   ##
=======================================
  Coverage   69.74%   69.74%           
=======================================
  Files          27       27           
  Lines        1094     1094           
=======================================
  Hits          763      763           
  Misses        298      298           
  Partials       33       33           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95ae738...7f8353a. Read the comment docs.

@svishwanath-tw svishwanath-tw merged commit 4ed9b84 into thoughtworks:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants