Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override user's diff.noprefix config #399

Merged
merged 1 commit into from Feb 3, 2023
Merged

Override user's diff.noprefix config #399

merged 1 commit into from Feb 3, 2023

Conversation

redhoyasa
Copy link
Contributor

Purpose

Approach

Override the user's diff.noprefix config by forcing talisman to add src-prefix and dst-prefix flags when calling git diff

Screenshot

Screenshot 2022-10-12 at 4 30 50 PM

@redhoyasa redhoyasa changed the title adding source and dest prefix regardless user's noprefix config Override user's diff.noprefix config Oct 12, 2022
@redhoyasa
Copy link
Contributor Author

redhoyasa commented Oct 28, 2022 •
edited

Hi @jmatias, could you please take a look at this?

Thanks!

@svishwanath-tw
Copy link
Collaborator

@redhoyasa : A test for these changes would be highly appreciated.

@jmatias jmatias merged commit 5ee48f7 into thoughtworks:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svishwanath-tw svishwanath-tw svishwanath-tw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

talisman breaks when gitconfig.diff.noprefix=true
3 participants
@redhoyasa @svishwanath-tw @jmatias