Add support for specifying secrets via env variables (Fixes #466) #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thp
requested changes
Mar 22, 2020
There was a problem hiding this comment.
This wouldn't work, when it is first launched, it will generate the default config based on the environment variables.
You should make it so that when loading the config from the file, the environment variables are queried and updated and runtime (and also to make sure the environment variable values do not end up in the config file).
|
Travis CI failed this PR, I'm closing it for now, but feel free to reopen with code style issues and review comments fixed (+ documented in the recently-added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.