Add reporter: Prowl App #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prowl is a simple iOS push notification service that grew out of the desire to forward MacOS 'Growl' notifications to iOS. It has a simple web API that can be used to create arbitrary push notifications to be sent to a user's device.
thp
reviewed
Apr 5, 2021
thp
reviewed
Apr 5, 2021
thp
reviewed
Apr 5, 2021
thp
reviewed
Apr 5, 2021
thp
reviewed
Apr 5, 2021
When building a command argument list for subprocess.Popen(), add options that require an argument as separate list elements. This results in a list like this: 2021-02-05 12:33:37,880 html2txt DEBUG: Command: ['html2text', '-nobs', '-utf8', '-width', '132'], stdout encoding: utf-8 instead of: 2021-02-05 12:33:37,880 html2txt DEBUG: Command: ['html2text', '-nobs', '-utf8', '-width 132'], stdout encoding: utf-8 which produces a CLI options parsing error because there is no option called '-width 132'.
|
Fantastic feedback! (also I'm a bit new to Python, is there an easy way to run a PEP-8 (and other PEP) checkers locally?) Okay! All those changes made, except the UTF-8 one, as I just wanted to confirm with you before I did: What I read in the requests docs, it says it converts all the keys to UTF-8, and that values should avoid passing unicode, which makes it seem possible? The prowl api does does specify UTF-8. The requests docs also mentions that all values should be strings, so should I be stringifying What do you think? Or I guess rather: what would you prefer :) Thanks for the feedback and super expedant review! |
thp
approved these changes
Apr 9, 2021
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prowl is a web-based push notification platform not unlike Pushover or Pushbullet.
I added it as it's the one I personally use, and thought perhaps someone else out there might get use from it too.