SendmailMailer: specify envelope from on the command line #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thp
requested changes
Oct 10, 2021
diabonas
force-pushed
the
sendmail-envelope-from
branch
from
14431c4
to
dce348d
Compare
An "envelope from" is useful e.g. for msmtp to choose the correct SMTP account based on the From address (https://marlam.de/msmtp/msmtp.html#Choosing-an-account). On the other hand, -f is a standard sendmail option (https://man7.org/linux/man-pages/man8/sendmail.8.html), so it shouldn't disrupt other implementations.
diabonas
force-pushed
the
sendmail-envelope-from
branch
from
dce348d
to
aa91e02
Compare
|
Thank you for your review! I amended the commit accordingly to include the changelog entry as suggested. |
thp
approved these changes
Oct 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An "envelope from" is useful e.g. for msmtp to choose the correct SMTP account based on the From address
(https://marlam.de/msmtp/msmtp.html#Choosing-an-account). On the other hand,
-fis a standard sendmail option (https://man7.org/linux/man-pages/man8/sendmail.8.html), so it shouldn't disrupt other implementations.