feat: correct auth redirect target

thraizz · Mar 9, 2024 · 2ee41be · 2ee41be
1 parent 77ccaa2
commit 2ee41be
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/router.tsx b/src/router.tsx
@@ -5,7 +5,7 @@ import { Authentication } from "./views/Authentication";
 import {
   RedirectIfNotLoggedIn,
   RedirectIfSignedIn,
-} from "./utils/RedirectIfNotLoggedIn";
+} from "./utils/AuthRedirects";
 import { Goals } from "./views/Goals";
 import { NewLayout } from "./views/NewLayout";
 import { routes } from "./routes";

diff --git a/src/utils/RedirectIfNotLoggedIn.tsx → src/utils/AuthRedirects.tsx b/src/utils/RedirectIfNotLoggedIn.tsx → src/utils/AuthRedirects.tsx
@@ -5,11 +5,17 @@ import { UserContext } from "../provider/UserContext";
 export const RedirectIfNotLoggedIn = ({ children }: PropsWithChildren) => {
   const { user } = useContext(UserContext);
 
-  return !user?.uid ? <Navigate to="/login" replace /> : children;
+  const target = "/login" + `?redirect=${window.location.pathname}`;
+
+  return !user?.uid ? <Navigate to={target} replace /> : children;
 };
 
 export const RedirectIfSignedIn = ({ children }: PropsWithChildren) => {
   const { user } = useContext(UserContext);
 
-  return user?.uid ? <Navigate to="/dashboard" replace /> : children;
+  const query = new URLSearchParams(window.location.search);
+
+  const target = query.get("redirect") || "/dashboard";
+
+  return user?.uid ? <Navigate to={target} replace /> : children;
 };