Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in gateio_wrapper.go , it should be 'y' #1544

Closed
aaabigfish opened this issue May 15, 2024 · 2 comments
Closed

Bug in gateio_wrapper.go , it should be 'y' #1544

aaabigfish opened this issue May 15, 2024 · 2 comments
Assignees
@shazbert

Comments

@aaabigfish
Copy link

aaabigfish commented May 15, 2024 •
edited
Loading

https://github.com/thrasher-corp/gocryptotrader/blob/34ef09dad655a5db059eb44941a7eb9467f8f447/exchanges/gateio/gateio_wrapper.go#L1609C52-L1609C53

side, err = order.StringToOrderSide(spotOrders[x].Orders[x].Side)
replace to
side, err = order.StringToOrderSide(spotOrders[x].Orders[y].Side)
@aaabigfish aaabigfish changed the title It should be y Bug in gateio_wrapper.go , it should be 'y' May 15, 2024
@shazbert
Copy link
Collaborator

@aaabigfish Nice spotting! Thanks for letting us know I will include a fix for this in #1532

@shazbert shazbert self-assigned this May 15, 2024
@shazbert shazbert mentioned this issue May 15, 2024
Merged
15 tasks
@thrasher-
Copy link
Collaborator

PR 1532 has been merged, thanks for reporting this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shazbert shazbert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thrasher- @shazbert @aaabigfish