Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature+Bugfix: Engine websocket management #360

Merged

Commits on Oct 1, 2019

  1. Initial commit tearing down the websocket connection management. The …

    …purpose is to remove the traffic monitoring and dropping as syncer.go is a better manager
    gloriousCode committed Oct 1, 2019
    Copy the full SHA
    3349c8b View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    a1ac2d2 View commit details
    Browse the repository at this point in the history
  3. Creates new WebsocketType struct to contain all parameters required. …

    …Deletes WebsocketReset. Utilises ReadMessageErrors channel for all websocket readmessages to analyse when an error returned is due to a disconnect
    gloriousCode committed Oct 1, 2019
    Copy the full SHA
    4a09537 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    d7056cb View commit details
    Browse the repository at this point in the history
  5. Simplifies initialisation function for websocket. Reconnects and resu…

    …bscribes after disconnection
    gloriousCode committed Oct 1, 2019
    Copy the full SHA
    13dd83f View commit details
    Browse the repository at this point in the history
  6. Adds WebsocketTimeout config value to dictate when the websocket traf…

    …fic monitor should die. Default to two minutes of no traffic activity. Increases test coverage and updates existing tests to work with new technologic. RE-ADDS TESTS I ACCIDENTALLY DELETED FROM PREVIOUS PR
    gloriousCode committed Oct 1, 2019
    Copy the full SHA
    0c5a619 View commit details
    Browse the repository at this point in the history
  7. Removes snapshot override as its always necessary when considering re…

    …connections. Increases test coverage. Re-adds tests that were ACCIDENTALLY DELETED. Removes unused websocket channels. Bug fix for traffic monitor to shutdown via goroutine instead of killing itself
    gloriousCode committed Oct 1, 2019
    Copy the full SHA
    7e08dc5 View commit details
    Browse the repository at this point in the history
  8. Fixes gateio bug for authentication errors when null. Adds little ent…

    …ry to syncer for when websocket is switched to rest and then back, you get a log notifying of the return. Fixes okgroup bug where ws message is sent on a disconnected ws, causing panic. Renames setConnectionStatus to setConnectedStatus. Puts connection monitor log behind verbose bool
    gloriousCode committed Oct 1, 2019
    Copy the full SHA
    1351e5a View commit details
    Browse the repository at this point in the history
  9. Fixes lingering races. Fixes bug where websocket was enabled whether …

    …you liked it or not. Removes demonstration test
    gloriousCode committed Oct 1, 2019
    Copy the full SHA
    48ca535 View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    5835087 View commit details
    Browse the repository at this point in the history
  11. Fixes data race

    gloriousCode committed Oct 1, 2019
    Copy the full SHA
    6831b80 View commit details
    Browse the repository at this point in the history
  12. Copy the full SHA
    305535a View commit details
    Browse the repository at this point in the history
  13. Copy the full SHA
    860669a View commit details
    Browse the repository at this point in the history
  14. Renames WsEnabled to Enabled. Increases test coverage. Fixes typo…

    …s. Handles unhandled errors
    gloriousCode committed Oct 1, 2019
    Copy the full SHA
    c77e4bd View commit details
    Browse the repository at this point in the history
  15. The forgotten lint

    gloriousCode committed Oct 1, 2019
    Copy the full SHA
    93217f1 View commit details
    Browse the repository at this point in the history
  16. With using RWlocks, removes the channel nil check and relies on !w.Is…

    …Connected() to prevent a shutdown from recurring
    gloriousCode committed Oct 1, 2019
    Copy the full SHA
    6e597df View commit details
    Browse the repository at this point in the history
  17. Copy the full SHA
    bf35184 View commit details
    Browse the repository at this point in the history
  18. Prevents timer channel hangups. Minimises use of websocket Connect().…

    … Expands disconnection error definition. Removes routine disconnection error handling. Ensures only one traffic monitor can ever be run. Renames subscriptionLock to subscriptionMutext for consistency
    gloriousCode committed Oct 1, 2019
    Copy the full SHA
    edce59a View commit details
    Browse the repository at this point in the history
  19. Copy the full SHA
    1949506 View commit details
    Browse the repository at this point in the history
  20. Copy the full SHA
    6fed94f View commit details
    Browse the repository at this point in the history
  21. Copy the full SHA
    7acb04d View commit details
    Browse the repository at this point in the history