Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump electron/npm depends for /web front-end #535

Merged
merged 3 commits into from Aug 6, 2020

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 4, 2020

Bumps electron from 3.0.8 to 7.2.4.

Release notes

Sourced from electron's releases.

electron v7.2.4

Release Notes for v7.2.4

Fixes

  • Fixed Promise timeout issue when running Electron as Node. #23324
  • Fixed a use-after-free error that could happen if a Tray was destroyed while showing a custom context menu. #23182
  • Fixed an issue where windows without nativeWindowOpen: true could invoke the non-native-open path. #23224
  • Fixed memory leak when using contextBridge with sandbox=true. #23232
  • MacOS VoiceOver is now able to find its way back into web contents after it navigated "out" of an application. #23174

electron v7.2.3

Release Notes for v7.2.3

Fixes

  • Security: Ensure proxy object is created in the correct context a9bead22

electron v7.2.2

Release Notes for v7.2.2

Fixes

  • Fixed a potential crash on invalid zoomFactor values when setting the zoom factor of a webpage. #22710
  • Fixed an issue with maximizable state persistence of BrowserWindows on macOS. #23019
  • Fixed an issue with possible creation of a messageBox which cannot be dismissed on macOS. #23089
  • Fixed an occasional crash when closing all BrowserWindows. #23024
  • Security: Backported fix for CVE-2020-6426: inappropriate implementation in V8. #23043
  • Security: backported a fix for crbug.com/1065094. #23059
  • Security: backported fix for a potential buffer overrun in WebRTC audio encoding. #23037
  • Security: backported fix for site isolation bypass in dedicated workers. #23040
  • Security: backported the fix to CVE-2020-6452: potential container-overflow in MediaStream mojo. #23044

Other Changes

  • Security: Backport fix for buffer underflow in DWrite. #22979
  • Security: Backported fix for use after free in file chooser. #22981
  • Security: backport fix for CVE-2020-6451: Use after free in WebAudio. #22945
  • Security: backport fix for use after free in VideoEncodeAccelerator. #22983
  • Security: backported fix for CVE-2019-20503: Out of bounds read in usersctplib. #22986
  • Security: backported fix for CVE-2020-6422: Use after free in WebGL. #23017
  • Security: backported fix for CVE-2020-6423: Use after free in audio. #23048
  • Security: backported fix for CVE-2020-6427: Use after free in audio. #23015
  • Security: backported fix for CVE-2020-6428: Use after free in audio. #23013
  • Security: backported fix for CVE-2020-6429: Use after free in audio. #23011
  • Security: backported fix for CVE-2020-6449: Use after free in audio. #23009
  • Security: backported fix for use-after-poison in WebAudio (crbug.com/1023810). #22869
  • Security: backported fix for use-after-poison in WebAudio. #22943
Commits
  • 0552e0d Bump v7.2.4
  • c87b474 refactor: port window-setup to use ctx bridge instead of being run in the mai...
  • 69683de fix: use Node's microtasks policy in node_main.cc (#23154) (#23324)
  • 8148b76 style: use build/include_directory for NOLINT (#23266) (#23304)
  • 7dfcb5e fix: block custom window.open when nativeWindowOpen is true (#23188) (#23224)
  • 0b3bf1e fix: do not mutate ipc instances across contexts (#23239)
  • fd529ac fix: do not allow child windows to specify their own preload script (#23229)
  • 3909001 fix: ensure that functions are not retained beyond their context being releas...
  • 039be2e build: improve patch filename remembering (#23070) (#23184)
  • fb6f604 fix: heap-use-after-free in tray.popUpContextMenu (#22842) (#23182)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 4, 2020
@thrasher- thrasher- changed the title Bump electron from 3.0.8 to 7.2.4 in /web Bump electron/npm depends for /web front-end Aug 5, 2020
@thrasher- thrasher- added nomerge Add this when you know the PR should not be merged but will remain open reconstructing Based on PR feedback, this is currently being reworked and is not to be merged labels Aug 5, 2020
@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #535 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #535      +/-   ##
==========================================
- Coverage   45.38%   45.36%   -0.02%     
==========================================
  Files         234      234              
  Lines       56449    56449              
==========================================
- Hits        25619    25610       -9     
- Misses      27994    28006      +12     
+ Partials     2836     2833       -3     
Impacted Files Coverage Δ
exchanges/lakebtc/lakebtc_websocket.go 55.15% <0.00%> (-2.07%) ⬇️
database/repository/withdraw/withdraw.go 59.92% <0.00%> (-1.17%) ⬇️
communications/slack/slack.go 63.59% <0.00%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e30756...013c25e. Read the comment docs.

@thrasher- thrasher- added review me This pull request is ready for review and removed nomerge Add this when you know the PR should not be merged but will remain open reconstructing Based on PR feedback, this is currently being reworked and is not to be merged labels Aug 5, 2020
Copy link
Contributor

@xtda xtda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and approved
current functionality works after dependancy bump

Copy link
Collaborator

@shazbert shazbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested windows 👍

Copy link
Collaborator

@gloriousCode gloriousCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK!

@thrasher- thrasher- merged commit 3107f70 into master Aug 6, 2020
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/web/electron-7.2.4 branch August 6, 2020 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file review me This pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants