add support for absolute path instead of .ftppass/env variables #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for passing the absolute path to a JSON file instead of the default `.ftppass` or the environment variables
**Example:**
_/home/JohnDoe/sftp/my-json-file.json_
```
{
"username": "your-username",
"keyLocation": "/path/to/your/key",
"password": "your-strong-password"
}
```
_Gruntfile.js_
```
"sftp-deploy": {
build: {
auth: {
host: 'my-ftp.com',
port: '5678',
authKey: '/home/JohnDoe/sftp/my-json-file.json'
}
...
}
}
```
| } else if (fs.existsSync(inKey)) { | ||
| var tmpStr = grunt.file.read(inKey); | ||
| var retVal = null; | ||
| if (inKey !== null && tmpStr.length) retVal = JSON.parse(tmpStr); |
There was a problem hiding this comment.
inKey !== null could be caught earlier in the else if expression. I think if it's missing we'll probably get an error above anyway.
|
Yeah, that's very true. I've tested it with all 3 methods (.ftppass, env variables, path), and when specifying unexisting values, the errors seem to be caught properly (i.e: "Warning: .ftppass seems to be missing or incomplete") |
thrashr888
added a commit
that referenced
this pull request
Jul 25, 2014
add support for absolute path instead of .ftppass/env variables
|
Looks good! Thanks. |
|
No problem, thanks to you for this useful grunt task. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To follow-up on my previous pull request (#47), this commit adds support for passing the absolute path to a JSON file in the
authKeyparameter instead of the .ftppass config or an environment variable.The user can seamlessly specify either of these, the grunt task will first check for an environment variable, then a path, or finally default back to .ftppass
Example:
/home/JohnDoe/sftp/my-json-file.json
{ "username": "your-username", "keyLocation": "/path/to/your/key", "password": "your-strong-password" }Gruntfile.js