StatsD plugin #102
Merged
StatsD plugin #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lirsacc
force-pushed
the
statsd-plugin
branch
4 times, most recently
from
4892ebd
to
233f3b8
Compare
lirsacc
force-pushed
the
statsd-plugin
branch
2 times, most recently
from
b9e96e0
to
2053cc1
Compare
We want to be able to monitor routemaster with Statsd based collectors so this PR adds a copy (pretty much grep-replace my way through it) of the Prometheus plugin but pushing to Statsd instead. This uses https://pypi.org/project/statsd-python/ so it's not Datadog specific + support tags (which https://pypi.org/project/python-statsd/ doesn't). I've also added the basic logger plugin test (not sure the other Prometheus specific tests are super relevant to copy) as well as docs + inclusion in build and release.
lirsacc
force-pushed
the
statsd-plugin
branch
from
2053cc1
to
442546a
Compare
lirsacc
force-pushed
the
statsd-plugin
branch
from
442546a
to
e860906
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first pass at a Statsd plugin given the Prometheus integration has been unreliable and we're moving to statsd based collections in general.
I think it's mostly there, but I need to check CI and I'd like to add some tests if possible. Also, for clarity I did not want to pull in specifically
datadogpyto remain generic and support other formats later if possible, but I coudn't find a good statsd client that supported tags so ended up hacking one around https://github.com/lirsacc/statsd_client_python.Ideally we'll run both for a bit and compare metrics.
The alternative to this would be to have Datadog or vector scrape the prometheus endpoint which is possible as well but a bit roundabout.