Update mypy #103
Merged
Update mypy #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
PeterJCLaw
force-pushed
the
update-mypy
branch
from
2b8ead0
to
a6ae075
Compare
PeterJCLaw
changed the base branch from
master
to
improve-middleware-correctness
PeterJCLaw
force-pushed
the
update-mypy
branch
from
ad5c20a
to
55c7ec7
Compare
PeterJCLaw
force-pushed
the
update-mypy
branch
2 times, most recently
from
9611fdb
to
1d40ec6
Compare
The only fix needed is to change our Feed dataclass so that it doesn't abuse the InitVar mechanism. Instead we declare 'data' as an instance variable explicitly as part of __post_init__, which mypy does understand and correctly allows.
mypy is now aware of implicit namespace packaging, so we need to be more explicit about what layer constitutes a package.
PeterJCLaw
force-pushed
the
update-mypy
branch
from
1d40ec6
to
64c37bd
Compare
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite and will continue to be automatically updated while this PR remains open. |
This was referenced Dec 1, 2021
Merged
Merged
Merged
lirsacc
approved these changes
Dec 6, 2021
tox.ini
Outdated
Comment on lines
43
to
46
| mypy -p routemaster --junit-xml build/results/typechecking.xml --exclude plugins | ||
| mypy plugins/routemaster-prometheus/routemaster_prometheus --junit-xml build/results/typechecking-plugins-prometheus.xml | ||
| mypy plugins/routemaster-sentry/routemaster_sentry --junit-xml build/results/typechecking-plugins-sentry.xml | ||
|
|
There was a problem hiding this comment.
There's also a statsd plugin now.
| @@ -1 +1,2 @@ | |||
| mypy==v0.560 | |||
| # 0.900 moves typeshed packages out, which we're not ready to switch to yet. | |||
There was a problem hiding this comment.
Can we not just install typeshed independently?
There was a problem hiding this comment.
Not the typeshed itself, no. This is about things like the types-dateutil package which now need to be installed separately. This is very solvable, I just hadn't included them here. Since this is now reviewed I'll leave this as is, but will pick up a separate PR which does this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only fix needed is to change our
Feeddataclass so that it doesn't abuse theInitVarmechanism. Instead we declaredataas an instance variable explicitly as part of__post_init__, which mypy does understand and correctly allows.