Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type (almost) all the things #122

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Type (almost) all the things #122

wants to merge 14 commits into from

Commits on Sep 24, 2022

  1. Move to a newer Circle CI convenience image 

    The old circleci/python images are deprecated.
    @PeterJCLaw
    PeterJCLaw committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    c81f772 View commit details
    Browse the repository at this point in the history

  2. CIRCLE_JOB is the new CIRCLE_STAGE

    @PeterJCLaw
    PeterJCLaw committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    ae37ef6 View commit details
    Browse the repository at this point in the history

  3. Tidy layout in this stub file

    @PeterJCLaw
    PeterJCLaw committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    3e22e91 View commit details
    Browse the repository at this point in the history

  4. Annotate these __repr__s

    @PeterJCLaw
    PeterJCLaw committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    8044aea View commit details
    Browse the repository at this point in the history

  5. Functions __name__'s are properties, not methods

    @PeterJCLaw
    PeterJCLaw committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    ddd9749 View commit details
    Browse the repository at this point in the history

  6. Make these ignores more specific

    @PeterJCLaw
    PeterJCLaw committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    17aa9c1 View commit details
    Browse the repository at this point in the history

  7. Make this signature match all the implementations

    @PeterJCLaw
    PeterJCLaw committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    657b091 View commit details
    Browse the repository at this point in the history

  8. Have mypy show and require error codes for clearer ignoring

    @PeterJCLaw
    PeterJCLaw committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    f62f4f8 View commit details
    Browse the repository at this point in the history

  9. Annotate almost everything 

    The majority of these were added via MonkeyType from running the
tests, with some manual adjustment afterwards. This also includes
some minor refactors where doing so made the types clearer.

This does leave one typing issue unresolved as it is highlighting
a potential bug.
    @PeterJCLaw
    PeterJCLaw committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    f3b1427 View commit details
    Browse the repository at this point in the history

  10. Remove unused type: ignores

    @PeterJCLaw
    PeterJCLaw committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    4401243 View commit details
    Browse the repository at this point in the history

  11. Spell these ignore codes correctly 

    I'm guessing these relate to older versions of mypy which didn't
know how to read the code, however it seems reasonable to assume
a newer enough version of mypy now.
    @PeterJCLaw
    PeterJCLaw committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    e16192d View commit details
    Browse the repository at this point in the history

  12. Silence this error for now

    @PeterJCLaw
    PeterJCLaw committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    8acb7c4 View commit details
    Browse the repository at this point in the history

  13. Drop unused noqa from typing imports 

    These were needed in very old versions of flake8, which didn't
support reading quoted type annotations.
    @PeterJCLaw
    PeterJCLaw committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    ecb7026 View commit details
    Browse the repository at this point in the history

  14. Allow type checking imports to violate layering 

    Ideally we probably wouldn't do this, however that would require
a fairly substantial re-working of where various types are defined
and/or introducing rather a lot of protocols. We maybe should do
that at some point, however until then it seems reasonable to
allow type checking imports to specifically sidestep the layering
constraints.
    @PeterJCLaw
    PeterJCLaw committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    7048fea View commit details
    Browse the repository at this point in the history