History in context #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterJCLaw
reviewed
Jan 15, 2018
routemaster/context.py
Outdated
| metadata: Dict[str, Any] = {}, | ||
| now: datetime.datetime = None, | ||
| feeds: Dict[str, Feed] = {}, | ||
| accessed_variables: Iterable[str] = [], |
There was a problem hiding this comment.
I'm not sure that having these mutable defaults is a good idea (maybe add flake8-mutable?).
Perhaps a better way to solve this would be a helper used in tests which handles the non-interesting defaults?
There was a problem hiding this comment.
I've fixed these with a test factory method that has the defaults (but not as mutable args).
routemaster/context.py
Outdated
| @@ -19,6 +19,7 @@ def __init__( | |||
| now: datetime.datetime = None, | |||
| feeds: Dict[str, Feed] = {}, | |||
| accessed_variables: Iterable[str] = [], | |||
| current_history_entry: Optional[Any] = None, | |||
There was a problem hiding this comment.
Do we really not have a type for the entry? Or is it that SqlAlchemy doesn't provide a useful type?
There was a problem hiding this comment.
The latter, because we aren't using the ORM. This will change eventually I hope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recommend reviewing per-commit here, it should be much simpler.