Add defaults values to context dependent destinations #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterJCLaw
approved these changes
Jan 16, 2018
routemaster/config/model.py
Outdated
| @@ -78,18 +78,19 @@ class ContextNextStates(NamedTuple): | |||
| """Defined a choice based on a path in the given `label_context`.""" | |||
| path: str | |||
| destinations: Iterable[ContextNextStatesOption] | |||
| default: str # noqa: E704 | |||
There was a problem hiding this comment.
For my understanding, since I can't find this despite searching, what error is E704? (I'd really like to see flake8 support pylint-style error names, but alas)
There was a problem hiding this comment.
I've added a comment, but it's basically a bug somewhere in flake8 or pycodestyle. I tried to create a failing test case for it in pycodestyle, but wasn't able to reproduce the failure (I'm not sure I understand their test case DSL format) and also that DSL doesn't seem to support differences between Python 2 and 3, and this is caused by the type annotation I believe.
My best guess is that this matches a regex that looks roughly like ^\s+def.+:.$
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.