Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example.yaml and add tests #46

Merged
merged 7 commits into from Apr 23, 2018
Merged

Update example.yaml and add tests #46

merged 7 commits into from Apr 23, 2018

Conversation

PeterJCLaw
Copy link
Contributor

@PeterJCLaw PeterJCLaw commented Mar 13, 2018

This updates the example.yaml to correct its interactions with feeds, its next-state destination specifications and adds some tests that the example is valid and loads.

@coveralls
Copy link

coveralls commented Apr 18, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling f667acd on update-example.yaml into 7c6c1c4 on master.

@PeterJCLaw
Copy link
Contributor Author

PeterJCLaw commented Apr 18, 2018

@danpalmer I've created a test that this loads and is valid, yet it's failing. When loading the config we appear to require that a state's next mapping contains a 'default' key when the next has a destinations, yet that doesn't match that schema. Does that reflect a bug in the loading code or the schema?

Currently the error that users see is a KeyError: 'default', so even if we can't actually express this in the schema I suggest that we output a nicer error.

@PeterJCLaw
Copy link
Contributor Author

I've raised the destinations/default quandary as #50 and will just make the example work for the moment.

Otherwise we get an error, though it's not clear if this is expected
(see #50).
@PeterJCLaw PeterJCLaw changed the title Update example.yaml Update example.yaml and add tests Apr 18, 2018
@danpalmer danpalmer merged commit 1be3552 into master Apr 23, 2018
@danpalmer danpalmer deleted the update-example.yaml branch April 23, 2018 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants