Connection Pooling #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prophile
reviewed
Apr 19, 2018
routemaster/feeds.py
Outdated
| @@ -20,6 +21,11 @@ class FeedNotFetched(Exception): | |||
| pass | |||
|
|
|||
|
|
|||
| @functools.lru_cache() | |||
| def _get_feed_session(): | |||
| return requests.Session() | |||
There was a problem hiding this comment.
These aren't thread-safe: I think this should be thread-local.
tomokas
reviewed
Apr 19, 2018
routemaster/feeds.py
Outdated
| @@ -20,6 +21,11 @@ class FeedNotFetched(Exception): | |||
| pass | |||
|
|
|||
|
|
|||
| @functools.lru_cache() | |||
There was a problem hiding this comment.
Using an explicit maxsize would be nice here, just saves a google to figure out what the connection pool size is.
There was a problem hiding this comment.
I've changed this to a thread local anyway, but unfortunately this probably wouldn't work as there's another layer of indirection within requests to the actual connection pool. There doesn't seem to be an easy way to expose the actual connection pool parameters here.
tomokas
approved these changes
Apr 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds connection pooling via
requests.Sessionto feeds and webhooks.