Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recent changes for SchedulerLimiter submit functions do not handle TestableSchedulers correctly #52

Closed
jentfoo opened this issue Dec 31, 2013 · 1 comment
Closed

Recent changes for SchedulerLimiter submit functions do not handle TestableSchedulers correctly #52

jentfoo opened this issue Dec 31, 2013 · 1 comment
Assignees
@jentfoo
Labels
bug
Milestone
1.0.0 Release!

Comments

@jentfoo
Copy link
Member

jentfoo commented Dec 31, 2013

The recent changes for Issue #50 caused this minor regression. It is only an issue if using the SchedulerLimiter with a TestableScheduler. Because we are using the ListenableFutureTask instead of the ListenableFutureVirtualTask, we can not pass the factory through to the class.

After reflection we should do one of the following:

  • Remove VirtualRunnable/VirtualCallable/VirtualLock design, and abandon the TestableScheduler
  • Change to the slightly less efficient ListenableFutureVirtualTask
@ghost ghost assigned jentfoo Dec 31, 2013
This was referenced Dec 31, 2013
Closed
Merged
@jentfoo
Copy link
Member Author

jentfoo commented Jan 2, 2014

This was fixed by merge #53

@jentfoo jentfoo closed this as completed Jan 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jentfoo jentfoo

Labels
bug
Milestone
1.0.0 Release!
Development

No branches or pull requests
1 participant
@jentfoo