TestableScheduler/VirtualLock/Virtual(Runnable/Callable) removal #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entation, and adds a lot of code. Furthermore I don't know of anyone currently using it, and although I think the implementation is solid, I worry about furture reqressions with other areas of code (see issue #51). So I am just experimenting at what the implementations would look like if this was removed.
… testable locks. We are now just returning Objects in their place to be synchronized on.
…hing, and the user has no reason to pass it in during construction.
|
Threadly-master #233 SUCCESS |
|
Threadly-unstable #378 SUCCESS |
ghost
assigned 
|
FWIW, this change reduces the compiled jar size by about 30KB |
lwahlmeier
added a commit
that referenced
this pull request
Jan 2, 2014
TestableScheduler/VirtualLock/Virtual(Runnable/Callable) removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible solution to issue #52. This removals all of the VirtualRunnable/VirtualCallable/VirtualLock infrastructure. This also removes the TestableScheduler implementation.
I am doing this as a pull request because I want to think about it, as well as get @lwahlmeier 's feedback on what he thinks about this. This removes a lot of functionality, and some of the test features of Threadly. Some thoughts to consider:
So I am torn, and want to think about this a bit before we commit to removing all this code.