Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show command without current module #87

Closed
maxzinkus opened this issue May 13, 2016 · 10 comments
Closed

Show command without current module #87

maxzinkus opened this issue May 13, 2016 · 10 comments
Assignees

Comments

@maxzinkus
Copy link
Contributor

If no module is currently selected, show should still be a valid command:

show with not argument should give Unknown command 'show '. You want to 'show creds' 'show exploits' 'show scanners' or 'show all'?

show all should print all the modules (creds, exploits, scanners)

show exploits should print all the exploits
etc.

And the relevant completions should be added.

@maxzinkus
Copy link
Contributor Author

I'm working on this, so no need to self-assign. PR incoming.

@BenjaminHCCarr
Copy link

I like the idea of show, as after pulling the git it is a little hard to get around blindly. My requsest to @deltaheavy wonderful addition was to also alias it to '?' and 'help' unless there is planned implementation for those commands.

@maxzinkus
Copy link
Contributor Author

Help does something else, implemented in the same PR :)

@maintainers
Would you like me to alias '?' to 'help'?

On Fri, May 13, 2016, 3:17 PM Ben notifications@github.com wrote:

I like the idea of show, as after pulling the git it is a little hard to
get around blindly. My requsest to @deltaheavy
https://github.com/DeltaHeavy wonderful addition was to also alias it
to '?' and 'help' unless there is planned implementation for those commands.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#87 (comment)

Max Zinkus

@lucyoa
Copy link
Contributor

lucyoa commented May 14, 2016

@deltaheavy @BenjaminHCCarr For now "help" is enough. Implementing alias '?' to 'help' might be quite tricky in current design. We are going to display information that "help" should be used if the provided input is not valid command.

@BenjaminHCCarr
Copy link

@lucyoa @deltaheavy the global show sounds similar to what I was looking for. I can't remember, I think some version of the "real" IOS used '?', that's all, no worries about complicating things. I just pulled, is help a WIP? I can't see any mention of "help" in the code other than in the wordlists and the 'help_text' entry. Great prodcut so far, really interested and liking it.

@BenjaminHCCarr
Copy link

BenjaminHCCarr commented May 14, 2016

Ignore me, I see the work in @deltaheavy fork tree.
https://github.com/DeltaHeavy/routersploit/tree/master/routersploit

@fwkz fwkz added this to the Bad Blood 2.2.0 milestone Jun 20, 2016
@lucyoa
Copy link
Contributor

lucyoa commented Jul 2, 2016

@deltaheavy have you played with this "show exploits, show scanners, show all, etc." functionality? It would be cool enhancement in addition to help command we already have.

@maxzinkus
Copy link
Contributor Author

I haven't looked at the code since about May. I seem to recall deciding
that you were going a different direction with the project than I wanted,
but for the life of me I can't remember what that direction was haha.

Sorry, loop me out on this one. I hope my small contributions were in line
with your development ideas, but for now I'm going to back out.

Thanks! Keep hacking on the thing, last I checked it was still a neat
project :)

On Sat, Jul 2, 2016, 10:04 AM Marcin Bury notifications@github.com wrote:

@deltaheavy https://github.com/DeltaHeavy have you played with this
"show exploits, show scanners, show all, etc." functionality? It would be
cool enhancement in addition to help command we already have.


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#87 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AFOJX0IqSFt5UET3aQnQKVilDu5ju6Ihks5qRpofgaJpZM4Ido9M
.

Max Zinkus

@fwkz fwkz mentioned this issue Jul 3, 2016
@fwkz fwkz self-assigned this Jul 3, 2016
@fwkz
Copy link
Collaborator

fwkz commented Jul 3, 2016

Feature available for tests in showall branch

@fwkz
Copy link
Collaborator

fwkz commented Jul 4, 2016

Feature in master branch.

@fwkz fwkz closed this as completed Jul 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants