trojan scanner #1178
Merged
trojan scanner #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenchy64
requested review from
agzam,
DeLaGuardo,
ereteog,
gbuisson,
irinarenteria,
msprunck,
obarbeau,
rplevy,
turbodog99,
wandersoncferreira and
yogsototh
as code owners
agzam
approved these changes
Dec 3, 2021
| "tmp/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*", | ||
| "tmp/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*" | ||
| ] | ||
| } |
There was a problem hiding this comment.
Interesting Christmas tree :)
| "goog/format/internationalizedemailaddress.js", | ||
| "swagger-ui/swagger-ui-bundle.js" | ||
| ] | ||
| } |
There was a problem hiding this comment.
How did you find out what needs to be excluded? Just curious.
There was a problem hiding this comment.
Start with an empty vector, iterate and add exclusions for things that seemed plausible to need bidi chars.
| ;; FIXME logged: https://github.com/advthreat/iroh/issues/6060 | ||
| ;; erm, there's something wrong with ctia's META-INF/license directory, | ||
| ;; it cannot be unzipped with jar. | ||
| ;; java.io.IOException: META-INF/license : could not create directory |
There was a problem hiding this comment.
Looks like a permission issue 🤷
There was a problem hiding this comment.
Here's how to reproduce:
lein uberjar
cd target
jar xf ctia.jar
| rm -rf tmp/trojansourcedetector | ||
| mkdir -p tmp/trojansourcedetector | ||
| cd tmp/trojansourcedetector | ||
| curl -sLO https://github.com/haveyoudebuggedit/trojansourcedetector/releases/download/v1.0.1/trojansourcedetector_1.0.1_linux_amd64.tar.gz |
There was a problem hiding this comment.
What happens if it fails to fetch it?
There was a problem hiding this comment.
set -e fails the script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related https://github.com/advthreat/iroh/issues/6052
Scans repository every build, and uberjar before every deployment.
There's something wrong with CTIA's uberjar. Worked around it and logged here: https://github.com/advthreat/iroh/issues/6060
§ QA
No QA is needed.
§ Release Notes
§ Squashed Commits