Properly filter Relationships to assemble a Feed View #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbuisson
requested review from
yogsototh,
msprunck,
ereteog,
frenchy64,
turbodog99,
rplevy,
wandersoncferreira,
DeLaGuardo,
obarbeau,
marioaquino,
safi,
t2sw and
brookeswanson
as code owners
johnejardine
pushed a commit
that referenced
this pull request
Apr 8, 2024
<!-- Specify linked issues and REMOVE THE UNUSED LINES --> > **Epic** # > Close # > Related advthreat/iroh#9111 Here are the steps to render a Feed in CTIA: 1. Fetch the feed document 2. Fetch the referenced indicator 3. Fetch all the relationships of the indicator 4. Fetch all the objects referenced by the `source_ref` field of the relationships 5. extract the observables from the Judgements and render the response The query on step 3 is too naive as it attempts to list any kind of relationship even though we're looking only for indicators with an "element-of" relationship_type, some indicators are linked to a very large number of Sightings, retrieving them consumes a huge amount of resources and ultimately leads to a failure. This PR updates the filter so we only fetch the proper indicators relevant for a Feed. <!-- UNCOMMENT THIS SECTION IF NEEDED <a name="iroh-services-clients">[§](#iroh-services-clients)</a> IROH Services Clients ===================================================================================== Put all informations that need to be communicated to IROH Services Clients. Typically IROH-UI, ATS Integration, Orbital, etc... --> <a name="qa">[§](#qa)</a> QA ============================ Describe the steps to test your PR. 1. Create and Query a Feed 2. The functionality should still work as expected and there should be no regression <!-- UNCOMMENT THIS SECTION IF NEEDED <a name="ops">[§](#ops)</a> Ops =============================== Specify Ops related issues and documentation - Config change needed: threatgrid/tenzin# - Migration needed: threatgrid/tenzin# - How to enable/disable that feature: (ex remove service from `bootstrap.cfg`, add scope to org) --> <!-- UNCOMMENT THIS SECTION IF NEEDED <a name="documentation">[§](#documentation)</a> Documentation ============================================================= Public Facing documentation section; - Public documentation updated needed: threatgrid/iroh-ui# See internal [doc file](./services/iroh-auth/doc/public-doc.org) --> <a name="release-notes">[§](#release-notes)</a> Release Notes ============================================================= <!-- REMOVE UNUSED LINES --> ``` public: Feed performance improvements ```
|
Verified on TEST in rel v2.17.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the steps to render a Feed in CTIA:
source_reffield of the relationshipsThe query on step 3 is too naive as it attempts to list any kind of relationship even though we're looking only for indicators with an "element-of" relationship_type, some indicators are linked to a very large number of Sightings, retrieving them consumes a huge amount of resources and ultimately leads to a failure.
This PR updates the filter so we only fetch the proper indicators relevant for a Feed.
§ QA
Describe the steps to test your PR.
§ Release Notes