Scopes intersection / scope-difference / scopes-missing #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msprunck
approved these changes
Jun 24, 2019
yogsototh
force-pushed
the
scopes-intersection
branch
from
0d47adb
to
57bd136
Compare
yogsototh
force-pushed
the
scopes-intersection
branch
from
57bd136
to
e66ec8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a scope-intersection, that perform what would be an intuitive intersection between two set of scopes.
scope-difference, was also updated with the same idea in mind, and it is no more restricted to just root scopes, but any scope could work. Still an exception will be throw if there is an inconsistency.
the old behavior of scope-difference is still kept under the name scopes-missing.
The doc and test were improved.