Private topic form user names #183

[glebm]

• Autocomplete user names remotely. Private topic form user names #183
• Fix autocomplete styles to use thredded form styles.
• Add $thredded-form-color/background variables.
• Avoid creating notification jobs when seeding, bump the number of
  records, and log progress.
• Fix includes in topics and private topics controller. There is still
  an issue of loading read state for each topic, but this can't be fixed
  easily due to the decorator architecture.
• Update DbTextSearch to 0.2.0 for indexed prefix matching in user search.
• Fix Messageboard slugs to allow creating messageboards with reserved
  names.
• Update changelog

[jayroh]

I like how you deferred slug_candidates to the private method below, returning that array. What about doing the same with this array of possible route conflicts? That removes the need for the comment to describe the "why". The method name would describe it sufficiently

# ...
reserved_words: possible_route_conflicts

private

def possible_route_conflicts
  %w(messageboards private-topics autocomplete-users theme-preview)
end

[glebm]

Acknowledged, but can't pass a symbol here, and any method called here would need to be defined beforehand (above). We could add a constant but then it can't be private I think.

[jayroh]

Good point, man. Good point. Forgot that that is in the class scope.

If there's a way to accomplish that where it's not obnoxious, then I'd lean towards that but if not - don't worry about it.

[jayroh]

Just a few comments on this but I'll leave them up to you :)

Otherwise, let's get this merged in when you're ready!