Global Search #215
Merged
Global Search #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Search across all messageboards. For now, uses the same controller#action, but the routes are separate so the global search can use a different action in the future, e.g. one that groups the results by Messageboard names. Resolves #211
| @@ -32,6 +32,11 @@ en: | |||
| private_topics: | |||
| errors: | |||
| user_ids_length: Please specify at least one other user. | |||
| search: | |||
| form: | |||
| btn_submit: :thredded.search.form.label | |||
There was a problem hiding this comment.
Full disclosure - I'm an i18n dummy. I haven't fully i18n'd an app to this day (I regret that, by the way).
That being said - is it common practice to shorten "button" to "btn"? If that's not a convention, I'd lean towards expanding this out. If it's a convention, please ignore me :)
There was a problem hiding this comment.
btn is a common abbreviation of button, popularized by Bootstrap. Example: Discourse.
|
Just one comment here @glebm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search across all messageboards.
For now, uses the same controller#action, but the routes are separate
so the global search can use a different action in the future, e.g. one
that groups the results by Messageboard names.
Resolves #211