Permalink URLs for posts and private posts #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,7 +2,8 @@ | |||
| Thredded::Engine.routes.draw do | |||
| resource :theme_preview, only: [:show], path: 'theme-preview' if %w(development test).include? Rails.env | |||
|
|
|||
| page_constraint = { page: /[1-9]\d*/ } | |||
| positive_int = /[1-9]\d*/ | |||
| page_constraint = { page: positive_int } | |||
| @@ -6,7 +6,8 @@ class Messageboard < ActiveRecord::Base | |||
| use: [:slugged, :reserved], | |||
| # Avoid route conflicts | |||
| reserved_words: ::Thredded::FriendlyIdReservedWordsAndPagination.new( | |||
| %w(messageboards preferences private-topics autocomplete-users theme-preview admin) | |||
| %w(messageboards preferences private-topics private-posts posts autocomplete-users | |||
| theme-preview admin) | |||
There was a problem hiding this comment.
This array has gotten big enough where it's a little bit of mental overhead to parse it on a quick look. Could you break these out into their own lines? It'd make diffs cleaner too.
|
Looks great @glebm - just a couple comments in there. |
Currently we send emails with the URL to the page of the topic where the post is at. However, when posts are deleted, the page may change. This introduces permalinks for posts and private posts that always redirect to the correct page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we send emails with the URL to the page of the topic where the
post is at. However, when posts are deleted the page may change.
This introduces permalinks for posts and private posts that always
redirect to the correct page.