Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Spoiler tags #701

Merged
merged 1 commit into from May 28, 2018
Merged

Feature: Spoiler tags #701

merged 1 commit into from May 28, 2018

Conversation

glebm
Copy link
Collaborator

@glebm glebm commented May 27, 2018

Spoiler tags can be added using <spoiler></spoiler> or [spoiler][/spoiler] markup (configurable via Thredded::SpoilerTagFilter.spoiler_tags).

Supported out of the box for any markup processor.
Spoilers are focusable and are activated on mousedown, spacebar, or enter.
They can also be nested.
Their accessibility role is "figure" and they have a dynamically updated aria-expanded attribute.

@glebm glebm added this to the v0.15.0 milestone May 27, 2018
@@ -126,6 +126,8 @@ zh-CN:
update_btn_submitting: :thredded.form.update_btn_submitting
pending_moderation_notice: 你的回复将在审核之后公开发表
quote_btn: 引用
spoiler_summary: 剧透 - 点击显示。
spoiler_summary_for_email: 扰流板 - 选择下面的内容来查看:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moondcr These have been translated via Google Translate, PTAL.

Spoiler tags can be added using <spoiler></spoiler> or
[spoiler][/spoiler] markup (configurable via
`Thredded::SpoilerTagFilter.spoiler_tags`).

Supported out of the box for any markup processor.
Spoilers are focusable and are activated on mousedown, spacebar, or enter.
They can also be nested.
Their accessibility role is "figure" and they have a dynamically updated
`aria-expanded` attribute.

In emails, a "select text to view" implementation is used instead, and
images are replaced with links.
@glebm glebm merged commit 2ef0f84 into 0-15-dev May 28, 2018
@glebm glebm deleted the spoiler-tag branch May 28, 2018 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant