Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messageboard grid: Incomplete rows up to 6 cells #754

Merged
merged 1 commit into from Oct 15, 2018
Merged

Conversation

glebm
Copy link
Collaborator

@glebm glebm commented Oct 15, 2018

A few forums that use Thredded are configured with a very large width limit for the messageboards page.

Our current styles only size up to 2 missing cells in incomplete rows correctly (using before and after pseudo-elements). This adds support for up to 5 missing cells in incomplete rows.

Some examples of the problem in the wild:

A few forums that use Thredded are configured with a very large width
limit for the messageboards page.

Our current styles only size up to two missing cells correctly (using
`before` and `after` pseudo-elements). This adds support for up to 5
missing cells in incomplete rows.
@glebm glebm requested a review from timdiggins October 15, 2018 02:41
Copy link
Collaborator

@timdiggins timdiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@glebm glebm merged commit 1bbd40a into master Oct 15, 2018
@glebm glebm deleted the cell-sizer branch October 15, 2018 12:43
@glebm glebm added this to the v0.16.1 milestone Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants