Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r126] Add SSRPass #27

Merged
merged 16 commits into from
Feb 25, 2021
Merged

[r126] Add SSRPass #27

merged 16 commits into from
Feb 25, 2021

Conversation

joshuaellis
Copy link
Member

Why

mrdoob/three.js@05cc046 – part of #2

What

Adds SSRPass and it's associated files

Checklist

  • Ready to be merged

@joshuaellis joshuaellis added this to the r126 milestone Feb 24, 2021
types/three/examples/jsm/postprocessing/SSRPass.d.ts Outdated Show resolved Hide resolved
types/three/examples/jsm/postprocessing/SSRPass.d.ts Outdated Show resolved Hide resolved
types/three/examples/jsm/postprocessing/SSRPass.d.ts Outdated Show resolved Hide resolved
types/three/examples/jsm/shaders/SSRShader.d.ts Outdated Show resolved Hide resolved
types/three/examples/jsm/objects/ReflectorForSSRPass.d.ts Outdated Show resolved Hide resolved
types/three/examples/jsm/objects/ReflectorForSSRPass.d.ts Outdated Show resolved Hide resolved
types/three/examples/jsm/objects/ReflectorForSSRPass.d.ts Outdated Show resolved Hide resolved
types/three/examples/jsm/postprocessing/SSRPass.d.ts Outdated Show resolved Hide resolved
@Methuselah96 Methuselah96 mentioned this pull request Feb 25, 2021
Closed
22 tasks
@joshuaellis
Copy link
Member Author

To do the generic change, i've merged master into this branch, since we're just focussing on r126, I think this should be fine on this opportunity.

@Methuselah96
Copy link
Contributor

Can we merge master into dev instead of this branch, just to make it clear what the changes are in this PR?

@joshuaellis
Copy link
Member Author

done. good thinking

@Methuselah96 Methuselah96 merged commit f00328c into dev Feb 25, 2021
@Methuselah96 Methuselah96 deleted the r126-ssrpass branch February 25, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants