Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ObjectLoader.d.ts #535

Merged
merged 5 commits into from
Jul 13, 2023
Merged

fix: ObjectLoader.d.ts #535

merged 5 commits into from
Jul 13, 2023

Conversation

ybt-new
Copy link
Contributor

@ybt-new ybt-new commented Jul 10, 2023

Returns an Object instead of an Array

Why

If you look at ObjectLoader.parseTextures

you will notice that the returned textures is an object instead of an array

ObjectLoader.parseMaterials also returns an object

@ybt-new ybt-new mentioned this pull request Jul 10, 2023
Closed
17 tasks
Methuselah96
Methuselah96 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@Methuselah96 Methuselah96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Methuselah96 Methuselah96 merged commit 3ff083f into three-types:master Jul 13, 2023
3 checks passed
@Methuselah96 Methuselah96 mentioned this pull request Jul 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Methuselah96 Methuselah96 Methuselah96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ybt-new @Methuselah96