Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing typo definition for DebugEnvironment #589

Merged
merged 5 commits into from
Aug 31, 2023

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Aug 30, 2023

Why

add missing typo definition

What

create DebugEnvironment.d.ts

See https://github.com/mrdoob/three.js/blob/master/examples/jsm/environments/DebugEnvironment.js

Also, fix the incorrect format in .all-contributorsrc file.

Checklist

  • Checked the target branch (current goes master, next goes dev)
  • Added myself to contributors table
  • Ready to be merged

@skyclouds2001 skyclouds2001 changed the title Patch 1 Add missing typo definition for DebugEnvironment Aug 30, 2023
@skyclouds2001 skyclouds2001 marked this pull request as ready for review August 30, 2023 04:46
@Methuselah96
Copy link
Contributor

@skyclouds2001 Thanks for the PR! Looks like DebugEnvironment.d.ts needs to be added to types/three/OTHER_FILES.txt since there are no tests that reference it.

@Methuselah96
Copy link
Contributor

Thanks!

@Methuselah96 Methuselah96 merged commit 28694ea into three-types:dev Aug 31, 2023
3 checks passed
@skyclouds2001 skyclouds2001 deleted the patch-1 branch September 1, 2023 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants