Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing boolean readonly props to lights and materials #711

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

michealparks
Copy link
Contributor

@michealparks michealparks commented Dec 17, 2023

Why

Currently it's difficult to type-narrow any class that does not have a typedef including an is* or type property that specifies a string constant as a value.

What

This PR starts to address this problem by adding missing boolean readonly props to Lights and Materials.

Checklist

  • Checked the target branch (current goes master, next goes dev)
  • Added myself to contributors table
  • Ready to be merged

Copy link
Contributor

@Methuselah96 Methuselah96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Methuselah96 Methuselah96 merged commit 42b32ab into three-types:master Dec 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants