Add set vertexShader for ShaderMaterial. #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johsin18 Could you please add setters and getters for uniforms, fragmentShader and vertexShader then. This might be useful. Thx. |
johsin18
force-pushed
the
set-vertexShader-for-ShaderMaterial
branch
from
6b581a3
to
9c67a70
Compare
|
Done. Please merge in the updated branch. |
nelsonsilva
added a commit
that referenced
this pull request
Dec 9, 2014
…rial Add set vertexShader for ShaderMaterial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need this setter for my application.
WebGLRenderer.setMaterialShaders does not suit my purpose, as it clones the uniforms, and adds unnecessary overhead.