Feature better table #155
Merged
Feature better table #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
- Coverage 80.29% 79.02% -1.28%
==========================================
Files 61 61
Lines 7070 7971 +901
==========================================
+ Hits 5677 6299 +622
- Misses 1393 1672 +279 |
grburgess
added
models
low level framework
|
|
||
| self._energies = np.array(store["energies"]) | ||
| processed_parameters += 1 |
There was a problem hiding this comment.
I think you can delete this processed_parameters variable? I don't see where it is used.
| this_parameter_number = int(tokens[0]) | ||
| this_parameter_name = str(tokens[1]) | ||
|
|
||
| assert ( |
There was a problem hiding this comment.
maybe change to log.error and AssertionError?
| @@ -86,6 +92,8 @@ def test_template_factory(): | |||
|
|
|||
| tm(energies) | |||
|
|
|||
| tm.clean() | |||
|
|
|||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Maybe add one more test to test the conversion from old table model to new one? Without that future changes in the table model may break this conversion without us noticing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #154 A new table model format is created that does not rely on pandas and a t.clean() member function is created that removes the interpolators when creating many table models.
A function to convert old table models from their format into the new one is created.
This frees us from relying on pandas to keep its HDF5 format stable.
This must be merged after #153 as I worked off this branch.