CPL added #159
CPL added #159
Conversation
|
@anastasia-tsvetkova you will need to run the script in /scripts/ python generate_test_data.py and move the newly created table to astromodels/data and update that table in the git |
| @@ -343,6 +343,83 @@ def evaluate(self, x, K, piv, index, xc): | |||
|
|
|||
| return result * unit_ | |||
|
|
|||
|
|
|||
| class CPL(Function1D, metaclass=FunctionMeta): | |||
There was a problem hiding this comment.
The use of CPL could be confusing as there is already a cutoff power law function. Moreover, we typically spell out the function name to be clear for users.
There was a problem hiding this comment.
fixed: CPL -> Cutoff_powerlaw_Ep
|
|
||
| A power law multiplied by an exponential cutoff parametrized via Ep | ||
|
|
||
| latex : $ K~\frac{x}{piv}^{index}~\exp{-x/xp} $ |
There was a problem hiding this comment.
is this the correct formula?
There was a problem hiding this comment.
no, thanks, fixed
| unit_ = 1.0 | ||
| K_, piv_, x_, index_, xp_ = K, piv, x, index, xp | ||
|
|
||
| result = nb_func.cplaw_eval(x_, K_, xp_, index_, piv_) |
There was a problem hiding this comment.
There was a new numba function cpp_eval created but it is not called here. However, there is really no need as you can write xc = xp (2+index) and pass this to cplaw_eval without the need for extra code.
| @@ -67,6 +67,20 @@ def cplaw_eval(x, K, xc, index, piv): | |||
| return out | |||
|
|
|||
|
|
|||
| @nb.njit(fastmath=True, cache=True) | |||
| def cpl_eval(x, K, xp, index, piv): | |||
There was a problem hiding this comment.
This function is not needed.
There was a problem hiding this comment.
deleted
Cutoff PL parameterized via Ep added