Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github action naar master research tools laten kijken #43

Open
wvangerwen opened this issue Jun 21, 2023 · 3 comments
Open

github action naar master research tools laten kijken #43

wvangerwen opened this issue Jun 21, 2023 · 3 comments

Comments

@wvangerwen
Copy link
Collaborator

wvangerwen commented Jun 21, 2023

Zodat we tests kunnen draaien zonder dat we de wijzigingen op researchtools moeten publishen op pypi.

ERROR: Invalid requirement: 'git https://github.com/hhnk-research-tools.git@master' (from line 12 of D:\a\hhnk-threedi-tools\hhnk-threedi-tools\envs\condaenv.1bxpn0lu.requirements.txt)
Installing pip dependencies: ...working... Ran pip subprocess with arguments:
@d2hydro
Copy link
Contributor

d2hydro commented Jun 22, 2023

Zodat we tests kunnen draaien zonder dat we de wijzigingen op researchtools moeten publishen op pypi.

ERROR: Invalid requirement: 'git https://github.com/hhnk-research-tools.git@master' (from line 12 of D:\a\hhnk-threedi-tools\hhnk-threedi-tools\envs\condaenv.1bxpn0lu.requirements.txt)
Installing pip dependencies: ...working... Ran pip subprocess with arguments:

Link should be git+https://github.com/HHNK/hhnk-research-tools.git@master

If I test this locally I get:

ERROR conda.core.link:_execute(740): An error occurred while installing package 'conda-forge::bzip2-1.0.8-h8ffe710_4'.
Rolling back transaction: done

[Errno 13] Permission denied: 'C:\\ProgramData\\miniconda3\\envs\\hhnk_threedi\\Library\\bin\\libbz2.dll'
()

What works:

  1. exclude hrt from environment_test.yml and create environment
  2. install hrt with pip install git+https://github.com/HHNK/hhnk-research-tools.git@master after

I've modified tests-conda.yml including:

      - name: Install hhnk-research_tools
        shell: pwsh
        run: pip install git+https://github.com/HHNK/hhnk-research-tools.git@master

Let's see how that goes

@d2hydro
Copy link
Contributor

d2hydro commented Jun 22, 2023

fixed met #42

@d2hydro d2hydro closed this as completed Jun 22, 2023
@wvangerwen
Copy link
Collaborator Author

ThreediRasters.initial_wlvl_2d toegevoegd in hrt. Action werkt na een uur nog niet.

https://github.com/threedi/hhnk-threedi-tools/actions/runs/5587900553/jobs/10213879818?pr=51

@d2hydro d2hydro reopened this Aug 17, 2023
@d2hydro d2hydro removed their assignment Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant