Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global 3bot admin #3299

Closed
xmonader opened this issue Sep 5, 2021 · 4 comments
Closed

Global 3bot admin #3299

xmonader opened this issue Sep 5, 2021 · 4 comments
Assignees
Milestone

Comments

@xmonader
Copy link
Collaborator

xmonader commented Sep 5, 2021

right now we currently allow admins of the "active identity" to login, and this got some users in trouble when they created identities and made them default without specifying their 3bot user as admin.

My suggestion is

  • global admin user in js config
  • allow authentication using any admin of the configured identities
@dmahmouali
Copy link
Contributor

suggestion:

  • In creating identity, add frontend and backend validation to make sure admins are not empty and verified 3Bot identities.

@xmonader
Copy link
Collaborator Author

xmonader commented Sep 8, 2021

suggestion:

  • In creating identity, add frontend and backend validation to make sure admins are not empty and verified 3Bot identities.

let's go with this option, reem also agrees with that one

@RafyAmgadBenjamin
Copy link
Contributor

After discussion with @xmonader, we reached to these solutions

  • while adding a new identity:
    • Add the logged-in user to admins
    • Add comma-separated admins
  • while setting an identity to be the default and this one doesn't have admins, we have to show a confirmation message that there are no admins

@MohamedElmdary
Copy link
Member

MohamedElmdary commented Sep 12, 2021

Fixed

Branch

development_admins_identity

Commit

49537d8

PR

#3314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants