Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor deployment deployer to stop using the host IDs in the network state #868

Closed
Tracked by #827
rawdaGastan opened this issue Feb 28, 2024 · 1 comment
Closed
Tracked by #827

Refactor deployment deployer to stop using the host IDs in the network state #868

rawdaGastan opened this issue Feb 28, 2024 · 1 comment
Assignees
@rawdaGastan
Labels
grid-client belongs to grid client type_feature New feature or request
Milestone
1.0.0

Comments

@rawdaGastan
Copy link
Collaborator

Is your feature request related to a problem? Please describe

Saving host IDs in network state is not needed anymore since we added list_private_ips call: threefoldtech/zos#2206

Describe the solution you'd like

refactor deployment deployer to stop using the host IDs in the network state.
@rawdaGastan rawdaGastan added type_feature New feature or request grid-client belongs to grid client labels Feb 28, 2024
@rawdaGastan rawdaGastan added this to the 1.0.0 milestone Feb 28, 2024
This was referenced Feb 28, 2024
Open
Open
@rawdaGastan rawdaGastan self-assigned this Feb 28, 2024
@rawdaGastan rawdaGastan mentioned this issue Feb 28, 2024
Merged
4 tasks
This was referenced Mar 12, 2024
Merged
Merged
@AbdelrahmanElawady
Copy link
Collaborator

Verified:

HostIDs was removed from network state here and list_private_ips is used here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rawdaGastan rawdaGastan

Labels
grid-client belongs to grid client type_feature New feature or request
Projects
3.14.x
Status: Done
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@rawdaGastan @AbdelrahmanElawady