Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor network state grid client #866

Merged
merged 14 commits into from
Mar 4, 2024
Merged

refactor network state grid client #866

merged 14 commits into from
Mar 4, 2024

Conversation

rawdaGastan
Copy link
Collaborator

@rawdaGastan rawdaGastan commented Feb 28, 2024 •
edited
Loading

Changes

  • Replacing host IDs in a local state with zos call for listing private ips
  • refactor generate versionless deployment to match the new function of assigning new ips
  • refactor assign vms ips
  • update tests

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstring

TODO

  • refactor k8s after the changes (assign ips)
  • refactor subnets of network state (needs refactoring the network deployer)

@rawdaGastan rawdaGastan changed the title Development refactor network state grid client refactor network state grid client Feb 28, 2024
@rawdaGastan rawdaGastan added the grid-client belongs to grid client label Feb 28, 2024
@rawdaGastan rawdaGastan force-pushed the development_refactor_network_state_grid_client branch from fe98866 to 4196f2b Compare February 28, 2024 09:55
@rawdaGastan
Merge branch 'development' of github.com:threefoldtech/tfgrid-sdk-go …
572f849 
…into development_refactor_network_state_grid_client
AbdelrahmanElawady
AbdelrahmanElawady requested changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@AbdelrahmanElawady AbdelrahmanElawady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! I think this should go to development_3.14 as this is still didn't reach mainnet

grid-client/deployer/deployment_deployer.go Outdated Show resolved Hide resolved
grid-client/deployer/deployment_deployer.go Outdated Show resolved Hide resolved
grid-client/deployer/deployment_deployer.go Outdated Show resolved Hide resolved
grid-client/deployer/deployment_deployer.go Show resolved Hide resolved
grid-client/deployer/deployment_deployer.go Outdated Show resolved Hide resolved
grid-client/deployer/deployment_deployer.go Outdated Show resolved Hide resolved
grid-client/deployer/deployment_deployer.go Outdated Show resolved Hide resolved
grid-client/deployer/deployment_deployer.go Show resolved Hide resolved
@rawdaGastan rawdaGastan changed the base branch from development to development_3.14 February 28, 2024 15:25
@rawdaGastan rawdaGastan changed the base branch from development_3.14 to development February 28, 2024 15:27
@rawdaGastan rawdaGastan changed the base branch from development to development_3.14 February 28, 2024 16:19
AbdelrahmanElawady
AbdelrahmanElawady requested changes Feb 29, 2024
View reviewed changes
grid-client/deployer/deployment_deployer.go Outdated Show resolved Hide resolved
grid-client/deployer/deployment_deployer.go Outdated Show resolved Hide resolved
grid-client/deployer/deployment_deployer.go Outdated Show resolved Hide resolved
grid-client/deployer/deployment_deployer.go Outdated Show resolved Hide resolved
@rawdaGastan rawdaGastan merged commit e09ed4b into development_3.14 Mar 4, 2024
36 of 37 checks passed
@rawdaGastan rawdaGastan deleted the development_refactor_network_state_grid_client branch March 4, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbdelrahmanElawady AbdelrahmanElawady AbdelrahmanElawady approved these changes

@muhamadazmy muhamadazmy Awaiting requested review from muhamadazmy

@MarioBassem MarioBassem Awaiting requested review from MarioBassem

@ashraffouda ashraffouda Awaiting requested review from ashraffouda

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

@xmonader xmonader Awaiting requested review from xmonader

@sameh-farouk sameh-farouk Awaiting requested review from sameh-farouk

@Eslam-Nawara Eslam-Nawara Awaiting requested review from Eslam-Nawara

Assignees
No one assigned
Labels
grid-client belongs to grid client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rawdaGastan @AbdelrahmanElawady