Skip to content
This repository has been archived by the owner on Jul 20, 2021. It is now read-only.

introduce rivbin binary encoder (taken from tfchain encoding contribution) #463

Closed
GlenDC opened this issue Nov 14, 2018 · 0 comments
Closed
Assignees
Milestone

Comments

@GlenDC
Copy link
Contributor

GlenDC commented Nov 14, 2018

Currently we have https://github.com/threefoldtech/rivine/tree/master/encoding, as the binary encoder for the Rivine project. It was taken from the original Sia fork and has remained active ever since.

tfchain (a Rivine-powered blockchain) introduced a new binary encoder, which you can currently find at https://github.com/threefoldfoundation/tfchain/tree/697475d32acde1c00fe7c94d02113ce2f205afbf/pkg/encoding. This will be the new Rivine binary encoder, which we can place under /pkg/encoding/rivbin. What is now under /encoding will be moved to /pkg/encoding/siabin. siabin will still be the default and only used binary encoder by Rivine. However, all primitive types will already support the rivbin encoder as well, such that other chains can already make use of it, should they want.

In a future issue we would than still need to decide how we could enable chains to use rivbin as the binary encoder for all purposes.

@GlenDC GlenDC added this to the 1.1.2 milestone Nov 14, 2018
@GlenDC GlenDC self-assigned this Nov 14, 2018
@GlenDC GlenDC added this to To do in scrum_tfchain_rivine_nov_2018 via automation Nov 14, 2018
@GlenDC GlenDC moved this from To do to In progress in scrum_tfchain_rivine_nov_2018 Nov 16, 2018
GlenDC added a commit that referenced this issue Nov 16, 2018
GlenDC added a commit that referenced this issue Nov 16, 2018
fixes partly #463, taken from tfchain encoding contribution
GlenDC added a commit that referenced this issue Nov 16, 2018
fixes partly #463, taken from tfchain encoding contribution
GlenDC added a commit that referenced this issue Nov 16, 2018
fixes partly #463, taken from tfchain encoding contribution
scrum_tfchain_rivine_nov_2018 automation moved this from In progress to Done Nov 19, 2018
@ghost ghost removed the state_inprogress label Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant