-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. just a typo
internal/explorer/server.go
Outdated
@@ -383,20 +384,48 @@ func (a *App) version(r *http.Request) (interface{}, mw.Response) { | |||
}, response | |||
} | |||
|
|||
// getNodeStatistics godoc | |||
// @Summary Show node statistics | |||
// @Description Get node statisitcs for more information about each node through the RMB relay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
statisitcs
-> statistics
and for your questions
I rushed merging, please add a follow up PR for what is needed
Need admin access on the repo?
I believe simply by issuing a get request on node statistics on the proxy and it should internally call the node on devnet
These are not used in the kubernetes deployment, ingress is handling the cert generation/tls, but they are there as a generic option for whenever the proxy is running isolated from kubernetes, in a VM for instance
let's open an issue here https://github.com/threefoldtech/rmb-sdk-go, Azmy should indeed version the repo if not done already |
Description
Adds a new endpoint for getting node statistics which includes workloads and deployments
Changes
Added dependency on RMB client
Added three new arguments in app:
tfchain-url
for the substrate client need for RMB clientrelay-url
for the RMB clientmnemonics
that represents a user on the network responsible to making calls to the relayImplemented new endpoint to get node statistics that contacts the node through the relay to get node statistics
Questions/Issues
domain
andtlsEmail
arguments are not configured as far as I can tellRelated Issues
Issue
Checklist