sort nodes by dedicated nodes #312
Conversation
alichaddad
requested review from
MarioBassem,
AhmedHanafy725,
Omarabdul3ziz,
sameh-farouk,
rawdaGastan and
AbdelrahmanElawady
as code owners
internal/explorer/db/postgres.go
Outdated
| @@ -464,6 +464,9 @@ func (d *PostgresDatabase) GetNodes(filter types.NodeFilter, limit types.Limit) | |||
| q = q.Limit(int(limit.Size)). | |||
| Offset(int(rand.Intn(int(count)) - int(limit.Size))) | |||
| } else { | |||
| if filter.AvailableFor != nil { | |||
| q = q.Order("(case when farm.dedicated_farm then 1 else 2 end)") | |||
There was a problem hiding this comment.
the dedicated nodes can be a node in a dedicated farm or a node with no contracts. can't we depend on the rent contract of the node? if it has a positive number, it means dedicated and rented so it can go to the top of the list
There was a problem hiding this comment.
Not sure what is the value we are depending on in the contract. Twin id?
There was a problem hiding this comment.
Also another thought, since dedicated property is the farm.dedicated_farm does that mean that we can't depend on that value to know if a node is dedicated or not?
There was a problem hiding this comment.
it's a bit confusing but will try to explain
dedicated -> farm.dedicated_farm: no deployments can go to this node unless it got rented
rentable -> dedicated node or node with no contracts: can be rented, also the nodes with no contracts can take deployments without a rent contract.
rented: one of the rentable nodes got rented, and then it will take a rentContractId. this rent contract id is 0 if the node is not rented. this one I mean to use to sort the nodes
using dedicated in the issue wasn't the correct word, it should be rented so I gonna rephrase it
alichaddad
force-pushed
the
development_order_dedicated_node
branch
from
db07f8e
to
1b890c6
Compare
Description
When listing node using
available_foroption show dedicated node first in the resultChanges
Related Issues
#311
Checklist